ok I play the guitar and when I'm playing something I've wrote and try to sing over it I always end up singing the guitar riff I'm wondering if you guys have any tips on how to sing independently of what I'm playing..
I never had singing lessons so this is probably a noob question, I don't do scales i just sing the songs I like, so am I supposed to check what key I'm in and than sing the notes on that key??

please help thank you
Same problem here when I play lead. It's fairly common among guitar players. That's why I don't sing and play lead at the same time. Any time I'm adding background vocals in my group, I stop playing lead until my vocal part is through.

It's something you can work through, but it takes a lot of work and practice.